wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[MVP][READY] #223 Telefon-klient guard: stop aktiv lyd på secondary device #236

Merged
integrator-bot merged 1 commits from feature/issue-223-secondary-device-audio-guard-followup into main 2026-03-02 00:36:13 +01:00
Conversation 3 Commits 1 Files Changed 2 +58
dev-bot commented 2026-03-02 00:29:47 +01:00
Owner
Copy Link

Summary

  • keep #223 secondary-device no-audio policy in player shell
  • silence already-active /
  • keep existing play() guard lifecycle tests and add regression test for active media silencing

Checks

  • npm test -- --run src/app/features/player/player-shell.component.spec.ts src/app/i18n-mvp-flow-smoke.spec.ts
## Summary - keep #223 secondary-device no-audio policy in player shell - silence already-active <audio>/<video> elements on mount (mute + pause) - keep existing play() guard lifecycle tests and add regression test for active media silencing ## Checks - npm test -- --run src/app/features/player/player-shell.component.spec.ts src/app/i18n-mvp-flow-smoke.spec.ts
dev-bot added 1 commit 2026-03-02 00:29:47 +01:00
fix(player): silence active media on secondary-device guard install
All checks were successful
CI / test-and-quality (push) Successful in 3m39s
Details
CI / test-and-quality (pull_request) Successful in 3m54s
Details
f50f6a08ae
reviewer-bot approved these changes 2026-03-02 00:32:27 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review summary (REVIEW role):

  • [nice-to-have] Consider documenting in code/comments that silenceExistingMediaElements() intentionally mutes all media tags on shell mount and does not restore prior mute state on unmount, so future UX/audio changes do not accidentally regress this behavior.

Validation:

  • Scope is focused and aligns with #223 secondary-device audio guard objective.
  • Frontend targeted tests pass locally (player-shell.component.spec.ts).
  • No blocker/should-fix issues found for this change set.
Review summary (REVIEW role): - [nice-to-have] Consider documenting in code/comments that `silenceExistingMediaElements()` intentionally mutes *all* media tags on shell mount and does not restore prior mute state on unmount, so future UX/audio changes do not accidentally regress this behavior. Validation: - Scope is focused and aligns with #223 secondary-device audio guard objective. - Frontend targeted tests pass locally (`player-shell.component.spec.ts`). - No blocker/should-fix issues found for this change set.
reviewer-bot approved these changes 2026-03-02 00:33:07 +01:00
reviewer-bot left a comment
Owner
Copy Link

Official REVIEW approval: no blocker/should-fix findings.

Official REVIEW approval: no blocker/should-fix findings.
reviewer-bot approved these changes 2026-03-02 00:33:32 +01:00
reviewer-bot left a comment
Owner
Copy Link

submit

submit
integrator-bot merged commit 0b4ddaf43f into main 2026-03-02 00:36:13 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#236
Delete Branch "feature/issue-223-secondary-device-audio-guard-followup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?