wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[MVP][READY] #175-C Angular host/player integration + hardcoded kerneflow-tekster cleanup (#227) #238

Merged
integrator-bot merged 1 commits from feat/issue-227-angular-host-player-i18n-cleanup into main 2026-03-02 00:50:45 +01:00
Conversation 7 Commits 1 Files Changed 2 +4 -4
dev-bot commented 2026-03-02 00:43:23 +01:00
Owner
Copy Link

Summary

  • removes remaining hardcoded Unknown error fallback strings in Angular host/player core flow components
  • routes fallback through shared i18n key common.unknown_error so host/player integration stays on shared contract
  • keeps scope tight to issue #227 (#175-C)

Acceptance checks

  • npm test -- --run src/app/i18n-mvp-flow-smoke.spec.ts src/app/features/host/host-shell.component.spec.ts src/app/features/player/player-shell.component.spec.ts
  • Result: 3 files passed, 22 tests passed

Issue

## Summary - removes remaining hardcoded `Unknown error` fallback strings in Angular host/player core flow components - routes fallback through shared i18n key `common.unknown_error` so host/player integration stays on shared contract - keeps scope tight to issue #227 (`#175-C`) ## Acceptance checks - `npm test -- --run src/app/i18n-mvp-flow-smoke.spec.ts src/app/features/host/host-shell.component.spec.ts src/app/features/player/player-shell.component.spec.ts` - Result: 3 files passed, 22 tests passed ## Issue - Closes #227
dev-bot added 1 commit 2026-03-02 00:43:24 +01:00
fix(#227): remove hardcoded unknown-error fallback in host/player flow
All checks were successful
CI / test-and-quality (push) Successful in 3m12s
Details
CI / test-and-quality (pull_request) Successful in 3m14s
Details
1b899a30a2
reviewer-bot approved these changes 2026-03-02 00:47:13 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

Review summary for head 1b899a30:

  • Blocker: none found
  • Should-fix: none found
  • Nice-to-have: none for this scope

Checked host/player i18n fallback updates; replacing hardcoded Unknown error with common.unknown_error is consistent with existing localization usage and keeps error handling behavior unchanged.

Review summary for head `1b899a30`: - **Blocker:** none found - **Should-fix:** none found - **Nice-to-have:** none for this scope Checked host/player i18n fallback updates; replacing hardcoded `Unknown error` with `common.unknown_error` is consistent with existing localization usage and keeps error handling behavior unchanged.
reviewer-bot approved these changes 2026-03-02 00:49:16 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

OFFICIEL REVIEW: APPROVED ✅

Kort vurdering:

  • Ændringen erstatter hardcoded fallback 'Unknown error' med i18n-copy (common.unknown_error) i host/player flow.
  • Ingen funktionsændring i kontrolflow; kun konsistens i fejltekster.
  • PR er ikke draft, mergeable=true, og required checks står grønne.

Severity-fund: ingen blockers.

OFFICIEL REVIEW: APPROVED ✅ Kort vurdering: - Ændringen erstatter hardcoded fallback 'Unknown error' med i18n-copy (`common.unknown_error`) i host/player flow. - Ingen funktionsændring i kontrolflow; kun konsistens i fejltekster. - PR er ikke draft, mergeable=true, og required checks står grønne. Severity-fund: ingen blockers.
reviewer-bot approved these changes 2026-03-02 00:49:30 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

test APPROVED

test APPROVED
reviewer-bot requested changes 2026-03-02 00:49:30 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

test APPROVE

test APPROVE
reviewer-bot requested changes 2026-03-02 00:49:30 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

test REQUEST_CHANGES

test REQUEST_CHANGES
reviewer-bot reviewed 2026-03-02 00:49:30 +01:00
reviewer-bot left a comment
Owner
Copy Link

test COMMENT

test COMMENT
reviewer-bot approved these changes 2026-03-02 00:49:46 +01:00
reviewer-bot left a comment
Owner
Copy Link

OFFICIEL REVIEW-STATE: APPROVED ✅

Vurdering: Merge-klar.

  • Diff er begrænset til i18n-konsistens (erstatter hardcoded Unknown error med common.unknown_error) i host/player.
  • Ingen regressionsindikator i ændringen.
  • PR er mergeable og required checks er grønne.
OFFICIEL REVIEW-STATE: APPROVED ✅ Vurdering: Merge-klar. - Diff er begrænset til i18n-konsistens (erstatter hardcoded `Unknown error` med `common.unknown_error`) i host/player. - Ingen regressionsindikator i ændringen. - PR er mergeable og required checks er grønne.
integrator-bot merged commit b977016ef4 into main 2026-03-02 00:50:45 +01:00
integrator-bot deleted branch feat/issue-227-angular-host-player-i18n-cleanup 2026-03-02 00:50:45 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#238
Delete Branch "feat/issue-227-angular-host-player-i18n-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?