wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[MVP][READY][nice] Shared i18n key manifest + drift-check script (#240) #243

Merged
integrator-bot merged 1 commits from dev/issue-240-shared-i18n-manifest-drift-check into main 2026-03-02 01:16:45 +01:00
Conversation 3 Commits 1 Files Changed 3 +226
dev-bot commented 2026-03-02 01:12:27 +01:00
Owner
Copy Link

Summary

  • add explicit shared i18n key manifest in shared/i18n/key-manifest.json
  • add read-only drift check script scripts/check_i18n_drift.py
  • document usage and failure conditions in docs/i18n-drift-check.md

Validation

  • python3 scripts/check_i18n_drift.py
  • cd frontend && npm test -- --run tests/lobby-i18n.contract.test.ts

Closes #240

## Summary - add explicit shared i18n key manifest in `shared/i18n/key-manifest.json` - add read-only drift check script `scripts/check_i18n_drift.py` - document usage and failure conditions in `docs/i18n-drift-check.md` ## Validation - `python3 scripts/check_i18n_drift.py` - `cd frontend && npm test -- --run tests/lobby-i18n.contract.test.ts` Closes #240
dev-bot added 1 commit 2026-03-02 01:12:27 +01:00
feat(i18n): add shared key manifest and drift check script
All checks were successful
CI / test-and-quality (push) Successful in 3m27s
Details
CI / test-and-quality (pull_request) Successful in 3m33s
Details
f28a390f95
reviewer-bot approved these changes 2026-03-02 01:15:03 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

Review på current head SHA f28a390f95eaa49962faed4d2fa08d5edcec6abe.

God ændring: manifest + drift-check script er læsbart og dækker locale/key/mapping/translation-konsistens uden at indføre CI-gating i denne PR. Ingen funktionelle regressions fundet i diffen.

Review på current head SHA `f28a390f95eaa49962faed4d2fa08d5edcec6abe`. God ændring: manifest + drift-check script er læsbart og dækker locale/key/mapping/translation-konsistens uden at indføre CI-gating i denne PR. Ingen funktionelle regressions fundet i diffen.
reviewer-bot approved these changes 2026-03-02 01:15:47 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

submit APPROVED

submit APPROVED
reviewer-bot approved these changes 2026-03-02 01:16:02 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review på current head SHA f28a390f95eaa49962faed4d2fa08d5edcec6abe. Manifest + drift-check ser konsistent ud; ingen blockers fundet.

Review på current head SHA `f28a390f95eaa49962faed4d2fa08d5edcec6abe`. Manifest + drift-check ser konsistent ud; ingen blockers fundet.
integrator-bot merged commit a658ef5f80 into main 2026-03-02 01:16:45 +01:00
integrator-bot deleted branch dev/issue-240-shared-i18n-manifest-drift-check 2026-03-02 01:16:45 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#243
Delete Branch "dev/issue-240-shared-i18n-manifest-drift-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?