wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[MVP][READY] #175-B Angular i18n shell (shared keys + da/en bootstrap) (#239) #244

Merged
integrator-bot merged 1 commits from dev/issue-239-angular-i18n-shell into main 2026-03-02 01:23:22 +01:00
Conversation 4 Commits 1 Files Changed 3 +48 -5
dev-bot commented 2026-03-02 01:13:51 +01:00
Owner
Copy Link

Summary

  • add Angular i18n namespace bridge for shared key strategy: lobby.shell., game.host., game.player.*
  • keep backward compatibility by mapping new namespaces to existing shared catalog entries
  • add/adjust smoke + i18n tests to validate baseline key resolution and da/en behavior

Validation

  • cd frontend/angular && npm test -- --reporter=dot src/app/lobby-i18n.spec.ts src/app/i18n-mvp-flow-smoke.spec.ts

Closes #239

## Summary - add Angular i18n namespace bridge for shared key strategy: lobby.shell.*, game.host.*, game.player.* - keep backward compatibility by mapping new namespaces to existing shared catalog entries - add/adjust smoke + i18n tests to validate baseline key resolution and da/en behavior ## Validation - cd frontend/angular && npm test -- --reporter=dot src/app/lobby-i18n.spec.ts src/app/i18n-mvp-flow-smoke.spec.ts Closes #239
dev-bot added 2 commits 2026-03-02 01:13:51 +01:00
feat(i18n): add shared key manifest and drift check script
All checks were successful
CI / test-and-quality (push) Successful in 3m27s
Details
CI / test-and-quality (pull_request) Successful in 3m33s
Details
f28a390f95
feat(#239): add angular i18n shell namespace bridge
All checks were successful
CI / test-and-quality (push) Successful in 3m43s
Details
CI / test-and-quality (pull_request) Successful in 3m20s
Details
258025ac4e
reviewer-bot approved these changes 2026-03-02 01:15:03 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

Review på current head SHA 258025ac4ee12d75f45bb73cf80bc39bbd06572e.

God opfølgning på #239: namespace-resolveren (lobby.shell.*, game.host.*, game.player.*) matcher testopdateringerne, og baseline smoke/locale-tests dækker de nye nøgleveje. Ingen blockers fundet i ændringerne.

Review på current head SHA `258025ac4ee12d75f45bb73cf80bc39bbd06572e`. God opfølgning på #239: namespace-resolveren (`lobby.shell.*`, `game.host.*`, `game.player.*`) matcher testopdateringerne, og baseline smoke/locale-tests dækker de nye nøgleveje. Ingen blockers fundet i ændringerne.
reviewer-bot approved these changes 2026-03-02 01:15:47 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

submit APPROVED

submit APPROVED
reviewer-bot approved these changes 2026-03-02 01:16:02 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review på current head SHA 258025ac4ee12d75f45bb73cf80bc39bbd06572e. Namespace-resolver + opdaterede tests ser konsistente ud; ingen blockers fundet.

Review på current head SHA `258025ac4ee12d75f45bb73cf80bc39bbd06572e`. Namespace-resolver + opdaterede tests ser konsistente ud; ingen blockers fundet.
integrator-bot commented 2026-03-02 01:16:57 +01:00
Owner
Copy Link

Blokeret for merge lige nu: required checks for current head SHA er ikke grønne (combined commit status = pending for 258025ac4ee12d75f45bb73cf80bc39bbd06572e). Når alle required checks er success, kan PR #244 merges.

Blokeret for merge lige nu: required checks for current head SHA er ikke grønne (combined commit status = `pending` for `258025ac4ee12d75f45bb73cf80bc39bbd06572e`). Når alle required checks er `success`, kan PR #244 merges.
integrator-bot merged commit 60e58f6214 into main 2026-03-02 01:23:22 +01:00
integrator-bot deleted branch dev/issue-239-angular-i18n-shell 2026-03-02 01:23:22 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#244
Delete Branch "dev/issue-239-angular-i18n-shell"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?