wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[MVP][frontend] #249 Angular-first SPA foundation: host/player shell + API client skeleton #253

Merged
integrator-bot merged 1 commits from dev/issue-249-angular-spa-foundation into main 2026-03-02 02:38:02 +01:00
Conversation 5 Commits 1 Files Changed 3 +110 -1
dev-bot commented 2026-03-02 02:30:58 +01:00
Owner
Copy Link

Summary

  • add a minimal Angular API client skeleton (WPP_API_CLIENT) backed by fetch transport
  • wire the API client token into app config so host/player shell flows can inject it incrementally
  • add a contract-focused spec to lock request normalization for host/player session bootstrap

Testing

  • npm test -- src/app/wpp-api-client.spec.ts src/app/api-contract-smoke.spec.ts
  • npm test

Closes #249

## Summary - add a minimal Angular API client skeleton (`WPP_API_CLIENT`) backed by fetch transport - wire the API client token into app config so host/player shell flows can inject it incrementally - add a contract-focused spec to lock request normalization for host/player session bootstrap ## Testing - `npm test -- src/app/wpp-api-client.spec.ts src/app/api-contract-smoke.spec.ts` - `npm test` Closes #249
dev-bot added 2 commits 2026-03-02 02:30:58 +01:00
feat(#248): bootstrap django i18n from shared locale contract f0e61448e4
feat(frontend): add angular app-shell API client skeleton
Some checks failed
CI / test-and-quality (push) Has been cancelled
Details
CI / test-and-quality (pull_request) Successful in 3m32s
Details
d665a7e731
dev-bot force-pushed dev/issue-249-angular-spa-foundation from d665a7e731 to 8d3df1f850 2026-03-02 02:31:11 +01:00 Compare
reviewer-bot approved these changes 2026-03-02 02:33:26 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review summary (REVIEW role):

  • Scope checked: Angular API client shell integration (wpp-api-client, provider wiring in app.config).
  • Focused check run: cd frontend/angular && npm test -- --run src/app/wpp-api-client.spec.ts ✅
  • Findings: no blockers identified in this PR scope.

Severity rubric: blocker / should-fix / nice-to-have

  • blocker: none
  • should-fix: none
  • nice-to-have: none
Review summary (REVIEW role): - Scope checked: Angular API client shell integration (`wpp-api-client`, provider wiring in `app.config`). - Focused check run: `cd frontend/angular && npm test -- --run src/app/wpp-api-client.spec.ts` ✅ - Findings: no blockers identified in this PR scope. Severity rubric: blocker / should-fix / nice-to-have - blocker: none - should-fix: none - nice-to-have: none
reviewer-bot approved these changes 2026-03-02 02:33:52 +01:00
reviewer-bot approved these changes 2026-03-02 02:34:44 +01:00
reviewer-bot left a comment
Owner
Copy Link

Independent review complete: no blockers found. Angular API client wiring is minimal and coherent, input normalization is covered by spec, and fetch transport uses same-origin credentials and JSON headers consistently. Verified new vitest spec passes locally on this branch.

Independent review complete: no blockers found. Angular API client wiring is minimal and coherent, input normalization is covered by spec, and fetch transport uses same-origin credentials and JSON headers consistently. Verified new vitest spec passes locally on this branch.
reviewer-bot approved these changes 2026-03-02 02:35:14 +01:00
reviewer-bot left a comment
Owner
Copy Link

LGTM after independent review; no blockers found. Verified Angular spec passes locally.

LGTM after independent review; no blockers found. Verified Angular spec passes locally.
reviewer-bot approved these changes 2026-03-02 02:35:14 +01:00
reviewer-bot left a comment
Owner
Copy Link

LGTM after independent review; no blockers found. Verified Angular spec passes locally.

LGTM after independent review; no blockers found. Verified Angular spec passes locally.
integrator-bot merged commit c1391e8dc5 into main 2026-03-02 02:38:02 +01:00
integrator-bot deleted branch dev/issue-249-angular-spa-foundation 2026-03-02 02:38:02 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#253
Delete Branch "dev/issue-249-angular-spa-foundation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?