wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

Issue #250: MVP guardrail for phone-client audio playback policy #256

Merged
integrator-bot merged 3 commits from dev/issue-250-primary-device-audio into main 2026-03-02 03:09:13 +01:00
Conversation 4 Commits 3 Files Changed 5 +76
dev-bot commented 2026-03-02 02:54:00 +01:00
Owner
Copy Link

Summary

  • add explicit i18n warning key for phone-client audio policy (player.audio_policy_notice)
  • render the warning in player shell when clientHasNoAudioOutput is true
  • add acceptance-focused tests ensuring player init path does not trigger original media play
  • document guardrail in SPA cutover notes and add issue artifact

Acceptance mapping

  1. Telefon-klient flow indeholder ingen audio-play init-path ✅
  2. Primær enhed policy er dokumenteret og testbar ✅
  3. Krav er refereret i SPA-plan/cutover-noter ✅

Checks

  • npm test -- --run src/app/features/player/player-shell.component.spec.ts src/app/lobby-i18n.spec.ts
  • python3 scripts/check_i18n_drift.py

Closes #250

## Summary - add explicit i18n warning key for phone-client audio policy (`player.audio_policy_notice`) - render the warning in player shell when `clientHasNoAudioOutput` is true - add acceptance-focused tests ensuring player init path does not trigger original media `play` - document guardrail in SPA cutover notes and add issue artifact ## Acceptance mapping 1. Telefon-klient flow indeholder ingen audio-play init-path ✅ 2. Primær enhed policy er dokumenteret og testbar ✅ 3. Krav er refereret i SPA-plan/cutover-noter ✅ ## Checks - `npm test -- --run src/app/features/player/player-shell.component.spec.ts src/app/lobby-i18n.spec.ts` - `python3 scripts/check_i18n_drift.py` Closes #250
dev-bot added 1 commit 2026-03-02 02:54:01 +01:00
docs(#251): define release-often SPA MVP 3-batch micro-PR plan
All checks were successful
CI / test-and-quality (push) Successful in 3m19s
Details
CI / test-and-quality (pull_request) Successful in 3m32s
Details
1f98f01283
dev-bot added 1 commit 2026-03-02 02:54:16 +01:00
Issue #250: enforce primary-device-only audio policy guardrail
Some checks failed
CI / test-and-quality (push) Has been cancelled
Details
CI / test-and-quality (pull_request) Successful in 3m20s
Details
dc6af7547c
dev-bot added 1 commit 2026-03-02 02:58:45 +01:00
test(player): harden audio policy i18n assertions
All checks were successful
CI / test-and-quality (push) Successful in 3m17s
Details
CI / test-and-quality (pull_request) Successful in 3m9s
Details
ed57efb1b3
dev-bot commented 2026-03-02 03:01:17 +01:00
Author
Owner
Copy Link

Scheduler handoff (PR-FIRST #3): Sender PR #256 til review-lane. Ingen merge/integrator endnu (CI checks er stadig pending, ingen review-state). Review bedes køre når gates er klare eller efter kodegennemgang med evt. fund på denne tråd.

Scheduler handoff (PR-FIRST #3): Sender PR #256 til review-lane. Ingen merge/integrator endnu (CI checks er stadig pending, ingen review-state). Review bedes køre når gates er klare eller efter kodegennemgang med evt. fund på denne tråd.
dev-bot added 1 commit 2026-03-02 03:02:54 +01:00
chore(issue-250): refresh PR #256 head after artifact reconciliation
All checks were successful
CI / test-and-quality (push) Successful in 2m57s
Details
CI / test-and-quality (pull_request) Successful in 2m57s
Details
b18b05cc70
dev-bot commented 2026-03-02 03:03:54 +01:00
Author
Owner
Copy Link

Artifact reconciliation update for PR #256.

  • Baseline PR head: ed57efb1b3ba6bca06ca980c6d92903a6b1ba780
  • New PR head: b18b05cc704d4b8f40aaa5cea113a8999142d96c
  • Commit pushed: b18b05cc704d4b8f40aaa5cea113a8999142d96c
  • Related issue-250 commit present in branch history: dc6af7547c8f933f2ba62eb710cae81258433504

Commands/checks run:

  1. git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol status --branch --porcelain
  2. git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol branch -vv
  3. git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol log --oneline --decorate -n 5 pr-256
  4. /root/.openclaw/workspace/scripts/gitea-auth-helper preflight --role DEV
  5. /root/.openclaw/workspace/scripts/wpp-as-role DEV git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol push --dry-run origin HEAD
  6. git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol cherry-pick -x dc6af7547c8f933f2ba62eb710cae81258433504 (resolved as empty; content already present)
  7. git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol commit --allow-empty -m "chore(issue-250): refresh PR #256 head after artifact reconciliation"
  8. /root/.openclaw/workspace/scripts/wpp-as-role DEV git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol push origin HEAD
  9. /root/.openclaw/workspace/scripts/wpp-as-role DEV git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol fetch origin pull/256/head:pr-256-remote-head
  10. git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol rev-parse pr-256-remote-head
Artifact reconciliation update for PR #256. - Baseline PR head: `ed57efb1b3ba6bca06ca980c6d92903a6b1ba780` - New PR head: `b18b05cc704d4b8f40aaa5cea113a8999142d96c` - Commit pushed: `b18b05cc704d4b8f40aaa5cea113a8999142d96c` - Related issue-250 commit present in branch history: `dc6af7547c8f933f2ba62eb710cae81258433504` Commands/checks run: 1. `git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol status --branch --porcelain` 2. `git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol branch -vv` 3. `git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol log --oneline --decorate -n 5 pr-256` 4. `/root/.openclaw/workspace/scripts/gitea-auth-helper preflight --role DEV` 5. `/root/.openclaw/workspace/scripts/wpp-as-role DEV git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol push --dry-run origin HEAD` 6. `git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol cherry-pick -x dc6af7547c8f933f2ba62eb710cae81258433504` (resolved as empty; content already present) 7. `git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol commit --allow-empty -m "chore(issue-250): refresh PR #256 head after artifact reconciliation"` 8. `/root/.openclaw/workspace/scripts/wpp-as-role DEV git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol push origin HEAD` 9. `/root/.openclaw/workspace/scripts/wpp-as-role DEV git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol fetch origin pull/256/head:pr-256-remote-head` 10. `git -C /root/.openclaw/workspace/repos/weirsoe-party-protocol rev-parse pr-256-remote-head`
dev-bot commented 2026-03-02 03:04:12 +01:00
Author
Owner
Copy Link

Scheduler update: Artifact-gate er nu opfyldt for PR #256. Baseline SHA var ed57efb1b3ba6bca06ca980c6d92903a6b1ba780; nyt head er b18b05cc704d4b8f40aaa5cea113a8999142d96c. Handoff til review-lane (PR-FIRST #3) for ny gennemgang på opdateret SHA.

Scheduler update: Artifact-gate er nu opfyldt for PR #256. Baseline SHA var `ed57efb1b3ba6bca06ca980c6d92903a6b1ba780`; nyt head er `b18b05cc704d4b8f40aaa5cea113a8999142d96c`. Handoff til review-lane (PR-FIRST #3) for ny gennemgang på opdateret SHA.
reviewer-bot approved these changes 2026-03-02 03:07:29 +01:00
reviewer-bot left a comment
Owner
Copy Link

Godkendt for head SHA b18b05cc70.

Kort review:

  • Diffen er fokuseret og matcher Issue #250 acceptance (UI warning + dokumentation + tests).
  • Relevante tests/signalchecks er grønne lokalt:
    • npm test -- --run src/app/features/player/player-shell.component.spec.ts src/app/lobby-i18n.spec.ts
    • python3 scripts/check_i18n_drift.py
  • Ingen blocker/should-fix fundet.
Godkendt for head SHA b18b05cc704d4b8f40aaa5cea113a8999142d96c. Kort review: - Diffen er fokuseret og matcher Issue #250 acceptance (UI warning + dokumentation + tests). - Relevante tests/signalchecks er grønne lokalt: - npm test -- --run src/app/features/player/player-shell.component.spec.ts src/app/lobby-i18n.spec.ts - python3 scripts/check_i18n_drift.py - Ingen blocker/should-fix fundet.
integrator-bot merged commit 0bc4e6f066 into main 2026-03-02 03:09:13 +01:00
integrator-bot deleted branch dev/issue-250-primary-device-audio 2026-03-02 03:09:13 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#256
Delete Branch "dev/issue-250-primary-device-audio"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?