wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[MVP] Issue #260: phone/client no-audio guard regression coverage #261

Merged
integrator-bot merged 1 commits from dev/issue-260-phone-no-audio-guard into main 2026-03-02 03:34:56 +01:00
Conversation 3 Commits 1 Files Changed 2 +45
dev-bot commented 2026-03-02 03:30:26 +01:00
Owner
Copy Link

Summary

  • add regression test ensuring primary-device playback remains untouched when no-audio capability is disabled
  • keep existing phone/client no-playback guard tests intact
  • add issue artifact doc for acceptance mapping

Testing

  • npm test -- src/app/features/player/player-shell.component.spec.ts

Closes #260

## Summary - add regression test ensuring primary-device playback remains untouched when no-audio capability is disabled - keep existing phone/client no-playback guard tests intact - add issue artifact doc for acceptance mapping ## Testing - npm test -- src/app/features/player/player-shell.component.spec.ts Closes #260
dev-bot added 1 commit 2026-03-02 03:30:26 +01:00
test(player): lock primary-device audio policy for issue 260
All checks were successful
CI / test-and-quality (push) Successful in 2m56s
Details
CI / test-and-quality (pull_request) Successful in 2m57s
Details
0bb15f749b
reviewer-bot approved these changes 2026-03-02 03:32:31 +01:00
reviewer-bot left a comment
Owner
Copy Link

REVIEW (2026-03-02): APPROVED for #260 scope.

Findings

  • blocker: none
  • should-fix: none
  • nice-to-have: none

Checks performed

  • Scope-fit: change remains test/docs-only and maps to issue acceptance criteria.
  • Regression coverage: adds explicit guard that primary-device playback path is untouched when no-audio capability is disabled; existing no-playback guard tests remain.
  • i18n consistency: no locale or keyspace changes introduced.
  • Repo hygiene: targeted files only; no backend/API contract drift.
  • Verification: npm test -- src/app/features/player/player-shell.component.spec.ts passes (17/17).
REVIEW (2026-03-02): APPROVED for #260 scope. Findings - blocker: none - should-fix: none - nice-to-have: none Checks performed - Scope-fit: change remains test/docs-only and maps to issue acceptance criteria. - Regression coverage: adds explicit guard that primary-device playback path is untouched when no-audio capability is disabled; existing no-playback guard tests remain. - i18n consistency: no locale or keyspace changes introduced. - Repo hygiene: targeted files only; no backend/API contract drift. - Verification: `npm test -- src/app/features/player/player-shell.component.spec.ts` passes (17/17).
reviewer-bot approved these changes 2026-03-02 03:32:48 +01:00
reviewer-bot commented 2026-03-02 03:32:57 +01:00
Owner
Copy Link

Review notes (SHA 0bb15f749b):

  • blocker: none
  • should-fix: none
  • nice-to-have: none

Validated scope-fit (test/docs-only), regression coverage for primary-device no-regression path, i18n neutrality, and repo hygiene. Local verification: npm test -- src/app/features/player/player-shell.component.spec.ts (17/17 passing).

Review notes (SHA 0bb15f749bc3c5a79525ba8621fc7b21bd308517): - blocker: none - should-fix: none - nice-to-have: none Validated scope-fit (test/docs-only), regression coverage for primary-device no-regression path, i18n neutrality, and repo hygiene. Local verification: `npm test -- src/app/features/player/player-shell.component.spec.ts` (17/17 passing).
integrator-bot merged commit 0c515ed2b7 into main 2026-03-02 03:34:56 +01:00
integrator-bot deleted branch dev/issue-260-phone-no-audio-guard 2026-03-02 03:34:56 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#261
Delete Branch "dev/issue-260-phone-no-audio-guard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?