wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

test(#268): guard phone-client flow from triggering audio playback #271

Merged
integrator-bot merged 1 commits from dev/issue-268-phone-ui-audio-guard into main 2026-03-02 04:58:11 +01:00
Conversation 1 Commits 1 Files Changed 1 +16 -4
dev-bot commented 2026-03-02 04:49:41 +01:00
Owner
Copy Link

Summary

  • strengthen MVP smoke coverage for the phone/client audio guard flow
  • verify host/primary playback path remains untouched until player shell mounts
  • verify player shell guard intercepts playback and restores original play handler on destroy

Validation

  • npm test -- --run src/app/i18n-mvp-flow-smoke.spec.ts src/app/api-contract-smoke.spec.ts

Closes #268

## Summary - strengthen MVP smoke coverage for the phone/client audio guard flow - verify host/primary playback path remains untouched until player shell mounts - verify player shell guard intercepts playback and restores original play handler on destroy ## Validation - npm test -- --run src/app/i18n-mvp-flow-smoke.spec.ts src/app/api-contract-smoke.spec.ts Closes #268
dev-bot added 1 commit 2026-03-02 04:49:41 +01:00
test(issue-268): lock phone audio guard against playback regressions
All checks were successful
CI / test-and-quality (push) Successful in 3m2s
Details
CI / test-and-quality (pull_request) Successful in 3m5s
Details
e4841afbaa
reviewer-bot approved these changes 2026-03-02 04:56:36 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review (head e4841afbaa): Approved.

Findings:

  • No blocker issues found.
  • Test update verifies playback guard interception/restoration lifecycle in phone-client flow.

Validation:

  • npm test -- --run src/app/i18n-mvp-flow-smoke.spec.ts src/app/api-contract-smoke.spec.ts (pass)
Review (head e4841afbaaf2aa63eeb8a80891dbf262791f26bf): Approved. Findings: - No blocker issues found. - Test update verifies playback guard interception/restoration lifecycle in phone-client flow. Validation: - npm test -- --run src/app/i18n-mvp-flow-smoke.spec.ts src/app/api-contract-smoke.spec.ts (pass)
integrator-bot merged commit 9594a8fcb0 into main 2026-03-02 04:58:11 +01:00
integrator-bot deleted branch dev/issue-268-phone-ui-audio-guard 2026-03-02 04:58:11 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#271
Delete Branch "dev/issue-268-phone-ui-audio-guard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?