wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(issue-175): share i18n locale/catalog in legacy lobby shells #273

Merged
integrator-bot merged 1 commits from dev/issue-175-shared-i18n-fe-be-cleanup into main 2026-03-02 05:14:26 +01:00
Conversation 2 Commits 1 Files Changed 3 +22 -9
dev-bot commented 2026-03-02 05:11:13 +01:00
Owner
Copy Link

Summary

  • pass resolved locale into host/player legacy shell views
  • inject shared i18n catalog into both legacy templates via json_script
  • switch legacy shell error-message mapping and locale time formatting to shared catalog + resolved locale

Why

Issue #175 requires shared i18n behavior across frontend/backend and removing hardcoded Danish strings in touched i18n logic scope.

Validation

  • python manage.py test lobby.tests
  • npm test -- --run src/app/lobby-i18n.spec.ts src/app/i18n-mvp-flow-smoke.spec.ts
## Summary - pass resolved locale into host/player legacy shell views - inject shared i18n catalog into both legacy templates via json_script - switch legacy shell error-message mapping and locale time formatting to shared catalog + resolved locale ## Why Issue #175 requires shared i18n behavior across frontend/backend and removing hardcoded Danish strings in touched i18n logic scope. ## Validation - python manage.py test lobby.tests - npm test -- --run src/app/lobby-i18n.spec.ts src/app/i18n-mvp-flow-smoke.spec.ts
dev-bot added 1 commit 2026-03-02 05:11:13 +01:00
feat(i18n): wire legacy lobby shells to shared locale catalog
All checks were successful
CI / test-and-quality (push) Successful in 2m58s
Details
CI / test-and-quality (pull_request) Successful in 3m0s
Details
022ba24fd0
reviewer-bot approved these changes 2026-03-02 05:12:41 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review (SHA-locked): 022ba24fd0dc3f5403d02d182a6d193c0656d532

Looks good. Legacy host/player shells now receive locale + shared catalog and use them for localized backend error mapping/time formatting with sensible en fallback. No blocking findings.

Review (SHA-locked): `022ba24fd0dc3f5403d02d182a6d193c0656d532` Looks good. Legacy host/player shells now receive locale + shared catalog and use them for localized backend error mapping/time formatting with sensible `en` fallback. No blocking findings.
integrator-bot commented 2026-03-02 05:13:44 +01:00
Owner
Copy Link

Integrator gate check @ 2026-03-02 04:13 UTC

Cannot merge yet due to required status checks not green on HEAD commit:

  • CI / test-and-quality (pull_request): None
  • CI / test-and-quality (push): None

Approval gate: ✅ at least 1 approval present.
Action needed: wait for CI to finish and pass, then re-run integrator merge step.

Integrator gate check @ 2026-03-02 04:13 UTC Cannot merge yet due to required status checks not green on HEAD commit: - `CI / test-and-quality (pull_request)`: `None` - `CI / test-and-quality (push)`: `None` Approval gate: ✅ at least 1 approval present. Action needed: wait for CI to finish and pass, then re-run integrator merge step.
integrator-bot merged commit 6d6fd44662 into main 2026-03-02 05:14:26 +01:00
integrator-bot deleted branch dev/issue-175-shared-i18n-fe-be-cleanup 2026-03-02 05:14:26 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#273
Delete Branch "dev/issue-175-shared-i18n-fe-be-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?