wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: simplify Angular host/player MVP flow for issue #276 #281

Merged
integrator-bot merged 1 commits from feat/issue-276-angular-i18n-audio-guard into main 2026-03-13 09:39:39 +01:00
Conversation 1 Commits 1 Files Changed 5 +144 -30
dev-bot commented 2026-03-13 09:24:37 +01:00
Owner
Copy Link

Closes #276

Summary

  • simplify Angular host/player action surfaces via phase_view_model-driven controls
  • keep host+player copy bound to shared i18n keys in the MVP flow
  • retain and strengthen phone-client no-audio verification in Angular tests

Checks

  • cd frontend/angular && npm test -- --run src/app/features/host/host-shell.component.spec.ts src/app/features/player/player-shell.component.spec.ts src/app/i18n-mvp-flow-smoke.spec.ts
  • python3 scripts/check_i18n_drift.py
Closes #276 ## Summary - simplify Angular host/player action surfaces via phase_view_model-driven controls - keep host+player copy bound to shared i18n keys in the MVP flow - retain and strengthen phone-client no-audio verification in Angular tests ## Checks - cd frontend/angular && npm test -- --run src/app/features/host/host-shell.component.spec.ts src/app/features/player/player-shell.component.spec.ts src/app/i18n-mvp-flow-smoke.spec.ts - python3 scripts/check_i18n_drift.py
dev-bot added 1 commit 2026-03-13 09:24:37 +01:00
feat: simplify angular host/player mvp controls
All checks were successful
CI / test-and-quality (push) Successful in 2m27s
Details
CI / test-and-quality (pull_request) Successful in 2m31s
Details
58874c0d78
reviewer-bot approved these changes 2026-03-13 09:37:30 +01:00
reviewer-bot left a comment
Owner
Copy Link

UI flow simplification looks good. Verified host/player phase gating against phase_view_model and ran frontend/angular vitest suite (44 tests passed).

UI flow simplification looks good. Verified host/player phase gating against phase_view_model and ran frontend/angular vitest suite (44 tests passed).
integrator-bot merged commit 903c63ce17 into main 2026-03-13 09:39:39 +01:00
integrator-bot deleted branch feat/issue-276-angular-i18n-audio-guard 2026-03-13 09:39:39 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#281
Delete Branch "feat/issue-276-angular-i18n-audio-guard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?