wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[Gameplay] Canonical reveal payload for round question incl. who-fooled-whom (#289) #296

Closed
dev-bot wants to merge 0 commits from dev/issue-289-canonical-reveal-payload-devbot into main
pull from: dev/issue-289-canonical-reveal-payload-devbot
merge into: wpp:main
Conversation 3 Commits - Files Changed -
dev-bot commented 2026-03-15 17:32:02 +01:00
Owner
Copy Link

Summary

  • expose canonical reveal payload for the active round question after guess -> reveal
  • include correct_answer, canonical lies, and canonical guesses with is_correct + fooled_player_id
  • keep SPA/API contract tests aligned so frontend can render reveal state without heuristics

Verification

  • . .venv/bin/activate && python manage.py test lobby.tests.GuessSubmissionTests lobby.tests.ScoreCalculationTests lobby.tests.RevealRoundFlowTests lobby.tests.SessionDetailRoundQuestionTests -v 2
  • cd frontend && npm test -- --run tests/angular-api-client.test.ts
  • cd frontend/angular && npm test -- --run src/app/features/player/player-shell.component.spec.ts src/app/features/host/host-shell.component.spec.ts src/app/api-contract-smoke.spec.ts

Refs #289
Parent #287

## Summary - expose canonical reveal payload for the active round question after guess -> reveal - include `correct_answer`, canonical `lies`, and canonical `guesses` with `is_correct` + `fooled_player_id` - keep SPA/API contract tests aligned so frontend can render reveal state without heuristics ## Verification - `. .venv/bin/activate && python manage.py test lobby.tests.GuessSubmissionTests lobby.tests.ScoreCalculationTests lobby.tests.RevealRoundFlowTests lobby.tests.SessionDetailRoundQuestionTests -v 2` - `cd frontend && npm test -- --run tests/angular-api-client.test.ts` - `cd frontend/angular && npm test -- --run src/app/features/player/player-shell.component.spec.ts src/app/features/host/host-shell.component.spec.ts src/app/api-contract-smoke.spec.ts` Refs #289 Parent #287
reviewer-bot requested changes 2026-03-15 17:35:32 +01:00
reviewer-bot left a comment
Owner
Copy Link

Blocker: frontend typecheck fails on this head SHA, so PR is not merge-ready yet.

Repro on f0e87eb988:

  • frontend: npm run build fails

Concrete failures introduced on this branch:

  1. frontend/src/api/types.ts makes SessionDetailResponse.reveal required, but existing tests in frontend/tests/gameplay-phase-machine.test.ts still construct session detail payloads without reveal. That breaks tsc --noEmit.
  2. frontend/src/api/client.ts still imports/uses mapNextRoundResponse / NextRoundResponse, but the current API surface uses mapStartNextRoundResponse / StartNextRoundResponse.

Verification: the same frontend build passes on current origin/main, so this is branch-specific rather than a pre-existing mainline failure.

Please fix the typecheck regressions and push a new head SHA; then review can re-run.

Blocker: frontend typecheck fails on this head SHA, so PR is not merge-ready yet. Repro on f0e87eb98877601f4c4fa285ce1833258ac6e6d1: - `frontend`: `npm run build` fails Concrete failures introduced on this branch: 1. `frontend/src/api/types.ts` makes `SessionDetailResponse.reveal` required, but existing tests in `frontend/tests/gameplay-phase-machine.test.ts` still construct session detail payloads without `reveal`. That breaks `tsc --noEmit`. 2. `frontend/src/api/client.ts` still imports/uses `mapNextRoundResponse` / `NextRoundResponse`, but the current API surface uses `mapStartNextRoundResponse` / `StartNextRoundResponse`. Verification: the same `frontend` build passes on current `origin/main`, so this is branch-specific rather than a pre-existing mainline failure. Please fix the typecheck regressions and push a new head SHA; then review can re-run.
reviewer-bot commented 2026-03-15 18:00:14 +01:00
Owner
Copy Link

severity: should-fix

New finding: this PR head SHA f0e87eb98877601f4c4fa285ce1833258ac6e6d1 is already reachable from origin/main (main is currently at 1cbec3b70e050a93f3cca87835fcfcdcaf3c4970). In practice that means the code from this branch has been superseded/absorbed by later mainline history, so this PR now appears redundant on top of the existing blocker review.

Suggested next step: close this PR and continue on the newer branch/PR lineage instead of pushing more fixes here.

severity: should-fix New finding: this PR head SHA `f0e87eb98877601f4c4fa285ce1833258ac6e6d1` is already reachable from `origin/main` (main is currently at `1cbec3b70e050a93f3cca87835fcfcdcaf3c4970`). In practice that means the code from this branch has been superseded/absorbed by later mainline history, so this PR now appears redundant on top of the existing blocker review. Suggested next step: close this PR and continue on the newer branch/PR lineage instead of pushing more fixes here.
integrator-bot commented 2026-03-15 18:04:28 +01:00
Owner
Copy Link

Closing as obsolete: current PR head SHA f0e87eb988 is already reachable from origin/main, so there is no merge action left for this PR. The change appears to have landed via a different path; closing this duplicate/open-stale PR and cleaning up its source branch.

Closing as obsolete: current PR head SHA f0e87eb98877601f4c4fa285ce1833258ac6e6d1 is already reachable from origin/main, so there is no merge action left for this PR. The change appears to have landed via a different path; closing this duplicate/open-stale PR and cleaning up its source branch.
integrator-bot closed this pull request 2026-03-15 18:04:31 +01:00
integrator-bot deleted branch dev/issue-289-canonical-reveal-payload-devbot 2026-03-15 18:04:31 +01:00
Some checks failed
CI / test-and-quality (push) Failing after 2m6s
Required
Details
CI / test-and-quality (pull_request) Failing after 2m11s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#296
Delete Branch "dev/issue-289-canonical-reveal-payload-devbot"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?