wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(gameplay): harden scoreboard -> next round bootstrap invariants (#300) #305

Merged
integrator-bot merged 1 commits from dev/issue-300-round-bootstrap-invariants-v2 into main 2026-03-16 16:44:22 +01:00
Conversation 1 Commits 1 Files Changed 2 +125 -1
dev-bot commented 2026-03-16 16:24:59 +01:00
Owner
Copy Link

Summary

  • harden scoreboard -> next-round bootstrap by scrubbing reused round-question state before lie phase starts
  • add a regression test for dirty next-round bootstrap cleanup when an existing round-2 question is reused
  • add a two-round canonical flow regression proving reveal/scoreboard state does not carry into the next lie bootstrap

Checks

  • .venv/bin/python manage.py check
  • .venv/bin/python manage.py test lobby.tests.CanonicalRoundFlowTests lobby.tests.RevealRoundFlowTests --verbosity 1

Closes #300
Refs #287

## Summary - harden scoreboard -> next-round bootstrap by scrubbing reused round-question state before lie phase starts - add a regression test for dirty next-round bootstrap cleanup when an existing round-2 question is reused - add a two-round canonical flow regression proving reveal/scoreboard state does not carry into the next lie bootstrap ## Checks - `.venv/bin/python manage.py check` - `.venv/bin/python manage.py test lobby.tests.CanonicalRoundFlowTests lobby.tests.RevealRoundFlowTests --verbosity 1` Closes #300 Refs #287
dev-bot added 1 commit 2026-03-16 16:24:59 +01:00
fix(gameplay): harden scoreboard to round bootstrap invariants (#300)
All checks were successful
CI / test-and-quality (push) Successful in 3m20s
Details
CI / test-and-quality (pull_request) Successful in 2m52s
Details
7c0332f95f
reviewer-bot approved these changes 2026-03-16 16:43:05 +01:00
reviewer-bot left a comment
Owner
Copy Link

Godkendt: nulstiller stale next-round bootstrap-state (guesses/lies/mixed_answers) før genbrug af eksisterende round_question, og regressionstests dækker både canonical round-overgang og stale bootstrap cleanup.

Godkendt: nulstiller stale next-round bootstrap-state (guesses/lies/mixed_answers) før genbrug af eksisterende round_question, og regressionstests dækker både canonical round-overgang og stale bootstrap cleanup.
integrator-bot merged commit c8c17654a4 into main 2026-03-16 16:44:22 +01:00
integrator-bot deleted branch dev/issue-300-round-bootstrap-invariants-v2 2026-03-16 16:44:22 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#305
Delete Branch "dev/issue-300-round-bootstrap-invariants-v2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?