wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

UI: guard submit-knapper indtil spillerkontekst er klar (#55) #56

Merged
integrator-bot merged 1 commits from feature/ui-submit-context-guard into main 2026-02-28 01:08:17 +01:00
Conversation 1 Commits 1 Files Changed 2 +11 -6
email-manager commented 2026-02-28 01:06:06 +01:00
Owner
Copy Link

Closes #55

Scope: #16 / #17

Need-to-have UI-guard:

  • lie/guess submit kræver nu komplet spillerkontekst (code, player_id, session_token, round_question_id)
  • tydelig status i UI når kontekst mangler
  • eksisterende lock-efter-submit flow bevaret

Validering:

  • ruff check lobby
  • python manage.py test lobby -v 1
Closes #55 Scope: #16 / #17 Need-to-have UI-guard: - lie/guess submit kræver nu komplet spillerkontekst (code, player_id, session_token, round_question_id) - tydelig status i UI når kontekst mangler - eksisterende lock-efter-submit flow bevaret Validering: - ruff check lobby - python manage.py test lobby -v 1
email-manager added 1 commit 2026-02-28 01:06:07 +01:00
ui(player): guard lie/guess submit until context is ready
All checks were successful
CI / test-and-quality (push) Successful in 1m36s
Details
CI / test-and-quality (pull_request) Successful in 1m37s
Details
1a988469ec
reviewer-bot approved these changes 2026-02-28 01:08:16 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review: ingen blockers. UI-guard og tests ser solide ud.

Review: ingen blockers. UI-guard og tests ser solide ud.
integrator-bot merged commit 0fe66f21c0 into main 2026-02-28 01:08:17 +01:00
integrator-bot deleted branch feature/ui-submit-context-guard 2026-02-28 01:08:17 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#56
Delete Branch "feature/ui-submit-context-guard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?