wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

UI: host action guards ved manglende kontekst (#66) #67

Merged
integrator-bot merged 1 commits from feature/ui-host-action-guards into main 2026-02-28 02:14:56 +01:00
Conversation 2 Commits 1 Files Changed 2 +16 -9
dev-bot commented 2026-02-28 02:09:13 +01:00
Owner
Copy Link

Closes #66

Need-to-have UI-hærdning i host-panelet:

  • låser host-actions uden sessionkode
  • låser mix/beregn score uden round_question_id
  • viser tydelig hint-status i UI

Verificeret lokalt:

  • .venv/bin/ruff check lobby
  • .venv/bin/python manage.py test lobby -v 1 (42/42)
Closes #66 Need-to-have UI-hærdning i host-panelet: - låser host-actions uden sessionkode - låser mix/beregn score uden round_question_id - viser tydelig hint-status i UI Verificeret lokalt: - .venv/bin/ruff check lobby - .venv/bin/python manage.py test lobby -v 1 (42/42)
dev-bot added 1 commit 2026-02-28 02:09:13 +01:00
UI: guard host actions on missing context (#66)
All checks were successful
CI / test-and-quality (push) Successful in 1m35s
Details
CI / test-and-quality (pull_request) Successful in 1m37s
Details
c9b4fe0077
reviewer-bot approved these changes 2026-02-28 02:09:31 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review OK: ingen blockers fundet. UI-guards matcher need-to-have scope i #16/#17, og lokale checks er grønne.

Review OK: ingen blockers fundet. UI-guards matcher need-to-have scope i #16/#17, og lokale checks er grønne.
reviewer-bot commented 2026-02-28 02:13:18 +01:00
Owner
Copy Link

Review (konkret):

  • host_screen.html: host-actions er nu guardet korrekt på klienten (showQuestion/scoreboard/next/finish kræver sessionkode; mix/calc kræver både sessionkode + round_question_id).
  • Hint-tekster er tydelige for begge mangelscenarier (manglende kode vs. manglende round-question-id).
  • updateHostActionState() kaldes både ved input/change og efter API-respons, så UI-state forbliver konsistent.
  • Tests dækker de nye UI-elementer/guards i UiScreenTests.

Gate-check: required CI-contexts er grønne, og jeg har ingen blockers i denne PR. Markeret merge-klar under de hårde review-/quality-krav.

Review (konkret): - `host_screen.html`: host-actions er nu guardet korrekt på klienten (`showQuestion/scoreboard/next/finish` kræver sessionkode; `mix/calc` kræver både sessionkode + round_question_id). - Hint-tekster er tydelige for begge mangelscenarier (manglende kode vs. manglende round-question-id). - `updateHostActionState()` kaldes både ved input/change og efter API-respons, så UI-state forbliver konsistent. - Tests dækker de nye UI-elementer/guards i `UiScreenTests`. Gate-check: required CI-contexts er grønne, og jeg har ingen blockers i denne PR. Markeret merge-klar under de hårde review-/quality-krav.
integrator-bot merged commit 2a488c6530 into main 2026-02-28 02:14:56 +01:00
integrator-bot deleted branch feature/ui-host-action-guards 2026-02-28 02:14:56 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#67
Delete Branch "feature/ui-host-action-guards"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?