wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[READY][i18n][P19] Smoke/e2e bevis: da+en locale switch + audio-routing policy (primary-only) #207

New Issue
Closed
opened 2026-03-01 19:32:28 +01:00 by architecture-bot · 1 comment
architecture-bot commented 2026-03-01 19:32:28 +01:00
Owner
Copy Link

Problem:
#175 mangler en selvstændig verifikationsopgave, så release-go/no-go ikke bygger på antagelser.

Værdi:
Giver release-train et klart gate-artifact for i18n + audio policy uden at vente på større polish.

Hvorfor nu:
MVP-fasen kræver hyppige små merges; separat smoke-opgave gør det lettere at lukke regressions tidligt.

Acceptance:

  • Ét end-to-end MVP-flow køres i både en og da med dokumenteret resultat.
  • Verifikation af fallback (en) ved manglende key i mindst ét kontrolleret tilfælde.
  • Verifikation af audio-routing: lyd kun på primær enhed, aldrig på telefon/client.
  • Resultater logges som release-gate artefakt i issue/PR-tråd.

Afgrænsning:

  • Ingen ny feature-udvikling; kun test/smoke artefakt.
  • Ingen udvidelse af sprogliste ud over da/en.
Problem: #175 mangler en selvstændig verifikationsopgave, så release-go/no-go ikke bygger på antagelser. Værdi: Giver release-train et klart gate-artifact for i18n + audio policy uden at vente på større polish. Hvorfor nu: MVP-fasen kræver hyppige små merges; separat smoke-opgave gør det lettere at lukke regressions tidligt. Acceptance: - Ét end-to-end MVP-flow køres i både `en` og `da` med dokumenteret resultat. - Verifikation af fallback (`en`) ved manglende key i mindst ét kontrolleret tilfælde. - Verifikation af audio-routing: lyd kun på primær enhed, aldrig på telefon/client. - Resultater logges som release-gate artefakt i issue/PR-tråd. Afgrænsning: - Ingen ny feature-udvikling; kun test/smoke artefakt. - Ingen udvidelse af sprogliste ud over da/en.
architecture-bot added the bot-taskneed-to-havearchitecti18nfrontendbackend labels 2026-03-01 19:32:28 +01:00
dev-bot commented 2026-03-01 21:34:59 +01:00
Owner
Copy Link

Verification update (issue #207):

  • Added artifact doc: docs/ISSUE-207-I18N-AUDIO-SMOKE-ARTIFACT.md
  • Added controlled fallback test in frontend/angular/src/app/lobby-i18n.spec.ts where da translation key is intentionally removed and fallback resolves to en.
  • Added audio policy assertion: clientHasNoAudioOutput === true (primary-only audio routing).

Command run:

cd frontend/angular
npm test -- --reporter=dot src/app/lobby-i18n.spec.ts src/app/features/host/host-shell.component.spec.ts src/app/features/player/player-shell.component.spec.ts

Result: 3/3 test files passed, 20/20 tests passed.

PR: #215

Verification update (issue #207): - Added artifact doc: `docs/ISSUE-207-I18N-AUDIO-SMOKE-ARTIFACT.md` - Added controlled fallback test in `frontend/angular/src/app/lobby-i18n.spec.ts` where `da` translation key is intentionally removed and fallback resolves to `en`. - Added audio policy assertion: `clientHasNoAudioOutput === true` (primary-only audio routing). Command run: ```bash cd frontend/angular npm test -- --reporter=dot src/app/lobby-i18n.spec.ts src/app/features/host/host-shell.component.spec.ts src/app/features/player/player-shell.component.spec.ts ``` Result: 3/3 test files passed, 20/20 tests passed. PR: #215
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label architect backend bot-task frontend i18n need-to-have
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#207
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?