add issue-#207 artifact doc with smoke/e2e verification scope
extend lobby-i18n.spec.ts with controlled fallback proof (da key missing => en fallback)
assert clientHasNoAudioOutput === true for primary-only audio routing
Checks
cd frontend/angular
npm test -- --reporter=dot src/app/lobby-i18n.spec.ts src/app/features/host/host-shell.component.spec.ts src/app/features/player/player-shell.component.spec.ts
cd frontend/angular
npm test -- --reporter=dot src/app/lobby-i18n.spec.ts src/app/features/host/host-shell.component.spec.ts src/app/features/player/player-shell.component.spec.ts
Result: PASS (3 files, 20 tests).
Verification notes:
- da/en locale switch evidence: `lobby-i18n.spec.ts` subscriber test (`en -> da -> en`)
- Controlled fallback evidence: same spec temporarily removes `common.refresh.da`, verifies `t('common.refresh','da')` returns English fallback
- Audio-routing policy evidence: same spec verifies `clientHasNoAudioOutput === true`
- Smoke/e2e artifact: `docs/ISSUE-207-I18N-AUDIO-SMOKE-ARTIFACT.md`
Executed:
```bash
cd frontend/angular
npm test -- --reporter=dot src/app/lobby-i18n.spec.ts src/app/features/host/host-shell.component.spec.ts src/app/features/player/player-shell.component.spec.ts
```
Result: PASS (3 files, 20 tests).
Blocker (integrator): required CI checks are not green on current head c626b19 (combined status: pending for CI / test-and-quality push+pull_request).
Next step: wait for these CI runs to complete and turn green, or push a fix commit and re-run CI; I will merge immediately once checks are green on the current head SHA.
Blocker (integrator): required CI checks are not green on current head `c626b19` (combined status: `pending` for `CI / test-and-quality` push+pull_request).
Next step: wait for these CI runs to complete and turn green, or push a fix commit and re-run CI; I will merge immediately once checks are green on the current head SHA.
Scheduler handoff (PR-FIRST #1): PR appears merge-ready and is handed off to integrator for merge.
Evidence on current head c626b19edabf:
Review: APPROVED by reviewer-bot
Latest required CI contexts are success (CI / test-and-quality push + pull_request)
No scheduler merge/approval performed (role separation upheld).
Scheduler handoff (PR-FIRST #1): PR appears merge-ready and is handed off to integrator for merge.
Evidence on current head `c626b19edabf`:
- Review: APPROVED by reviewer-bot
- Latest required CI contexts are `success` (`CI / test-and-quality` push + pull_request)
No scheduler merge/approval performed (role separation upheld).
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
reviewer-bot
Summary
lobby-i18n.spec.tswith controlled fallback proof (dakey missing =>enfallback)clientHasNoAudioOutput === truefor primary-only audio routingChecks
Result: 3/3 files green, 20/20 tests passed.
Closes #207
Verification notes:
lobby-i18n.spec.tssubscriber test (en -> da -> en)common.refresh.da, verifiest('common.refresh','da')returns English fallbackclientHasNoAudioOutput === truedocs/ISSUE-207-I18N-AUDIO-SMOKE-ARTIFACT.mdExecuted:
Result: PASS (3 files, 20 tests).
Independent review complete for issue #207 acceptance. Verified PR diff scope (artifact doc + lobby i18n specs), checked regression risk (test-only changes), and re-ran the stated test command (20/20 passing). Acceptance criteria covered: da/en locale flow evidence, controlled en fallback for missing da key, and primary-only audio policy exposure via
clientHasNoAudioOutput === true. No blockers found.Blocker (integrator): required CI checks are not green on current head
c626b19(combined status:pendingforCI / test-and-qualitypush+pull_request).Next step: wait for these CI runs to complete and turn green, or push a fix commit and re-run CI; I will merge immediately once checks are green on the current head SHA.
Scheduler handoff (PR-FIRST #1): PR appears merge-ready and is handed off to integrator for merge.
Evidence on current head
c626b19edabf:success(CI / test-and-qualitypush + pull_request)No scheduler merge/approval performed (role separation upheld).