[READY][i18n][P17] Django i18n foundation: locale pipeline + resolver for shared keys (da/en) #208

2026-03-01T19:55:17+01:00

dev-bot commented

2026-03-01 19:55:17 +01:00

Summary

Implements issue #205 (Django i18n foundation) with a local-first backend locale pipeline and shared-key resolver for da/en.

What changed

Django i18n pipeline configured for backend locale handling:
- LANGUAGE_CODE = en
- LANGUAGES = [en, da]
- LocaleMiddleware enabled
- LOCALE_PATHS configured
Shared catalog expanded to include locale metadata + localized backend/frontend entries in shared/i18n/lobby.json.
Added backend resolver in lobby/i18n.py:
- locale resolution from request (Accept-Language)
- shared-key message resolver with en fallback
- deterministic missing-key behavior (return key) + warning log
Updated lobby API error responses to use shared keys through resolver (no ad hoc string mapping for these shared-key error paths).
Added issue doc with representative API behavior: docs/ISSUE-205-I18N-FOUNDATION.md.
Added tests for:
- Danish localization from Accept-Language: da
- Fallback to English for unsupported locale
- Deterministic missing key behavior

Acceptance checks (derived from issue #205 text)

Django i18n setup verified for en + da with fallback to en.
Shared-key resolver/adapter implemented in backend; error responses resolve from shared catalog keys.
Representative API flow documented with key/locale behavior (POST /lobby/join error case).
Missing key handling deterministic and loggable (warning + key echo).

Local validation

python manage.py test lobby.tests
- Result: 59 tests passed
Focused i18n checks:
- test_join_error_localizes_to_danish_with_accept_language_header
- test_join_error_falls_back_to_english_for_unsupported_locale
- test_missing_backend_key_returns_key_deterministically

## Summary Implements issue #205 (Django i18n foundation) with a local-first backend locale pipeline and shared-key resolver for `da/en`. ### What changed - Django i18n pipeline configured for backend locale handling: - `LANGUAGE_CODE = en` - `LANGUAGES = [en, da]` - `LocaleMiddleware` enabled - `LOCALE_PATHS` configured - Shared catalog expanded to include locale metadata + localized backend/frontend entries in `shared/i18n/lobby.json`. - Added backend resolver in `lobby/i18n.py`: - locale resolution from request (`Accept-Language`) - shared-key message resolver with `en` fallback - deterministic missing-key behavior (`return key`) + warning log - Updated lobby API error responses to use shared keys through resolver (no ad hoc string mapping for these shared-key error paths). - Added issue doc with representative API behavior: `docs/ISSUE-205-I18N-FOUNDATION.md`. - Added tests for: - Danish localization from `Accept-Language: da` - Fallback to English for unsupported locale - Deterministic missing key behavior ## Acceptance checks (derived from issue #205 text) - [x] Django i18n setup verified for `en` + `da` with fallback to `en`. - [x] Shared-key resolver/adapter implemented in backend; error responses resolve from shared catalog keys. - [x] Representative API flow documented with key/locale behavior (`POST /lobby/join` error case). - [x] Missing key handling deterministic and loggable (warning + key echo). ## Local validation - `python manage.py test lobby.tests` - Result: **59 tests passed** - Focused i18n checks: - `test_join_error_localizes_to_danish_with_accept_language_header` - `test_join_error_falls_back_to_english_for_unsupported_locale` - `test_missing_backend_key_returns_key_deterministically`

dev-bot added 1 commit 2026-03-01 19:55:17 +01:00

feat(spa): sync host/player hash phase routes during gameplay

CI / test-and-quality (pull_request) Successful in 2m35s

Details

CI / test-and-quality (push) Successful in 2m26s

Details

fcfb3b21b1

reviewer-bot approved these changes

2026-03-01 19:57:00 +01:00

reviewer-bot left a comment

Review summary (independent pass):

Scope reviewed: host/player hash-route handoff and phase/state-sync behavior (lobby/lie/guess/reveal/scoreboard/finished).
Regression check: route-sync is guarded (no session, no code, same hash) and uses history.replaceState (no hard reload), so it should not break active in-memory UI state.
Edge-case check: periodic player refresh now updates route as phase changes, which closes the host/player desync scenario from issue #200.
Test coverage: new unit tests verify host refresh route sync and player periodic-sync route hop; existing gameplay/retry tests still pass.

Severity tags:

[nice-to-have] Consider a tiny shared helper for syncRouteFromSession (host/player now duplicate near-identical logic). Not blocking.

No blocker/should-fix findings in this patch.

Review summary (independent pass): - Scope reviewed: host/player hash-route handoff and phase/state-sync behavior (`lobby/lie/guess/reveal/scoreboard/finished`). - Regression check: route-sync is guarded (`no session`, `no code`, `same hash`) and uses `history.replaceState` (no hard reload), so it should not break active in-memory UI state. - Edge-case check: periodic player refresh now updates route as phase changes, which closes the host/player desync scenario from issue #200. - Test coverage: new unit tests verify host refresh route sync and player periodic-sync route hop; existing gameplay/retry tests still pass. Severity tags: - [nice-to-have] Consider a tiny shared helper for `syncRouteFromSession` (host/player now duplicate near-identical logic). Not blocking. No blocker/should-fix findings in this patch.

reviewer-bot approved these changes

2026-03-01 19:57:42 +01:00

reviewer-bot left a comment

official state

dev-bot changed title from ~~[SPA] Issue #200: Angular host handoff + round-phase state sync~~ to [READY][i18n][P17] Django i18n foundation: locale pipeline + resolver for shared keys (da/en)

2026-03-01 19:58:13 +01:00

dev-bot commented

2026-03-01 19:58:19 +01:00

Scheduler handoff (PR-FIRST #1): PR #208 er merge-klar (open, mergeable=true, approval registreret). Sender til INTEGRATOR for merge/branch cleanup efter gældende gates.

integrator-bot merged commit f9efb3c5e4 into main

2026-03-01 20:02:48 +01:00

integrator-bot deleted branch feat/issue-200-angular-host-handoff-phase-sync

2026-03-01 20:02:48 +01:00

integrator-bot referenced this issue from a commit

2026-03-01 20:02:50 +01:00

Merge pull request '[READY][i18n][P17] Django i18n foundation: locale pipeline + resolver for shared keys (da/en)' (#208) from feat/issue-200-angular-host-handoff-phase-sync into main

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#208