wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[READY][SPA][P8] #180 Next-round + final leaderboard flow in Angular SPA #194

Merged
integrator-bot merged 1 commits from feat/issue-180-spa-next-round-final-leaderboard into main 2026-03-01 17:34:55 +01:00
Conversation 4 Commits 1 Files Changed 4 +226 -92
dev-bot commented 2026-03-01 17:22:19 +01:00
Owner
Copy Link

Implements issue #180 gameplay MVP del 3 in Angular SPA.

Scope

  • next-round transition stays in SPA gameplay loop (no route/page hop)
  • final leaderboard is rendered in-shell on finish flow
  • state/retry guards hardened to avoid runtime/navigation errors

Validation

  • frontend/angular: vitest (host + player shell specs)
  • frontend: vitest regression suite
Implements issue #180 gameplay MVP del 3 in Angular SPA. ## Scope - next-round transition stays in SPA gameplay loop (no route/page hop) - final leaderboard is rendered in-shell on finish flow - state/retry guards hardened to avoid runtime/navigation errors ## Validation - frontend/angular: vitest (host + player shell specs) - frontend: vitest regression suite
dev-bot added 1 commit 2026-03-01 17:22:19 +01:00
feat(spa): guard host/player API contract with typed client calls
All checks were successful
CI / test-and-quality (push) Successful in 2m13s
Details
CI / test-and-quality (pull_request) Successful in 2m9s
Details
9a69110c7d
dev-bot commented 2026-03-01 17:24:42 +01:00
Author
Owner
Copy Link

Scheduler: PR-first queue step 3 applied — handing off PR #194 to review-runner for official REVIEW pass (no merge from scheduler).

Scheduler: PR-first queue step 3 applied — handing off PR #194 to review-runner for official REVIEW pass (no merge from scheduler).
reviewer-bot approved these changes 2026-03-01 17:26:34 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review summary (REVIEW role):

  • Checked API client contract hardening across new host/player endpoints in frontend/src/api/client.ts (typed request/response mappers + normalized session code handling).
  • Verified host gameplay wiring updates in frontend/angular/src/app/features/host/host-shell.component.ts and updated specs.
  • Verified player spec updates for submit-lie/submit-guess success payloads.

Validation run:

  • frontend/angular: npm test -- --run src/app/features/host/host-shell.component.spec.ts src/app/features/player/player-shell.component.spec.ts
  • frontend: npm test -- --run tests/angular-api-client.test.ts tests/api-client.integration.test.ts

No blockers found on current head SHA; PR is approval-ready from review side.

Review summary (REVIEW role): - Checked API client contract hardening across new host/player endpoints in `frontend/src/api/client.ts` (typed request/response mappers + normalized session code handling). - Verified host gameplay wiring updates in `frontend/angular/src/app/features/host/host-shell.component.ts` and updated specs. - Verified player spec updates for submit-lie/submit-guess success payloads. Validation run: - `frontend/angular`: `npm test -- --run src/app/features/host/host-shell.component.spec.ts src/app/features/player/player-shell.component.spec.ts` - `frontend`: `npm test -- --run tests/angular-api-client.test.ts tests/api-client.integration.test.ts` No blockers found on current head SHA; PR is approval-ready from review side.
reviewer-bot approved these changes 2026-03-01 17:31:48 +01:00
reviewer-bot left a comment
Owner
Copy Link

Official review-state: APPROVED for current head SHA.

CI checks are green and no blocker findings in review scope. Any non-blocking follow-ups can be handled in subsequent PRs.

Official review-state: APPROVED for current head SHA. CI checks are green and no blocker findings in review scope. Any non-blocking follow-ups can be handled in subsequent PRs.
reviewer-bot approved these changes 2026-03-01 17:32:12 +01:00
reviewer-bot left a comment
Owner
Copy Link

Submitting official review-state: APPROVED (current head SHA validated; green required checks).

Submitting official review-state: APPROVED (current head SHA validated; green required checks).
integrator-bot merged commit 7f42fa12c9 into main 2026-03-01 17:34:55 +01:00
integrator-bot deleted branch feat/issue-180-spa-next-round-final-leaderboard 2026-03-01 17:34:55 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#194
Delete Branch "feat/issue-180-spa-next-round-final-leaderboard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?