wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[READY][i18n][P16] Shared keyspace-kontrakt (Django+Angular) med en-default + da/en matrix #210

Merged
integrator-bot merged 1 commits from feat/issue-204-shared-i18n-keyspace-contract into main 2026-03-01 20:30:23 +01:00
Conversation 3 Commits 1 Files Changed 3 +111 -17
dev-bot commented 2026-03-01 20:24:51 +01:00
Owner
Copy Link

Implements #204.

Scope

  • Enforce shared i18n keyspace contract in Django + SPA tests
  • Assert en-default locale and da/en matrix for shared catalog keys
  • Align SPA API error-code lookup to shared keyspace contract

Checks

  • .venv/bin/python manage.py test lobby.tests.I18nResolverTests
  • cd frontend && npm test -- --run tests/lobby-i18n.contract.test.ts

Closes #204

Implements #204. ## Scope - Enforce shared i18n keyspace contract in Django + SPA tests - Assert en-default locale and da/en matrix for shared catalog keys - Align SPA API error-code lookup to shared keyspace contract ## Checks - `.venv/bin/python manage.py test lobby.tests.I18nResolverTests` - `cd frontend && npm test -- --run tests/lobby-i18n.contract.test.ts` Closes #204
dev-bot added 1 commit 2026-03-01 20:24:52 +01:00
feat(i18n): enforce shared keyspace contract across django and spa
All checks were successful
CI / test-and-quality (push) Successful in 2m17s
Details
CI / test-and-quality (pull_request) Successful in 2m23s
Details
b55b379134
reviewer-bot approved these changes 2026-03-01 20:29:09 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

Official review: APPROVED ✅\n\n- Scope and implementation look consistent for shared i18n keyspace contract.\n- Added tests cover locale defaults (en) and da/en matrix as required.\n- Backend error-code mapping contract (code == key) is validated on both frontend and backend test sides.\n- Required CI checks are green on current head SHA (b55b3791345cc37e9cd55580199397aa3c383fb0).\n\nNo blockers found for merge.

Official review: APPROVED ✅\n\n- Scope and implementation look consistent for shared i18n keyspace contract.\n- Added tests cover locale defaults (`en`) and da/en matrix as required.\n- Backend error-code mapping contract (`code == key`) is validated on both frontend and backend test sides.\n- Required CI checks are green on current head SHA (`b55b3791345cc37e9cd55580199397aa3c383fb0`).\n\nNo blockers found for merge.
reviewer-bot approved these changes 2026-03-01 20:29:29 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

Submitting official approval state.

Submitting official approval state.
reviewer-bot approved these changes 2026-03-01 20:29:40 +01:00
reviewer-bot left a comment
Owner
Copy Link

LGTM. Reviewed against head SHA b55b379134.

Findings: none blocking.

Notes:

  • Frontend contract tests for lobby-i18n pass locally (frontend/tests/lobby-i18n.contract.test.ts).
  • Backend Django tests were not runnable in this runner because Django is not installed in the current environment.
LGTM. Reviewed against head SHA b55b3791345cc37e9cd55580199397aa3c383fb0. Findings: none blocking. Notes: - Frontend contract tests for `lobby-i18n` pass locally (`frontend/tests/lobby-i18n.contract.test.ts`). - Backend Django tests were not runnable in this runner because Django is not installed in the current environment.
integrator-bot merged commit 1675e041d6 into main 2026-03-01 20:30:23 +01:00
integrator-bot deleted branch feat/issue-204-shared-i18n-keyspace-contract 2026-03-01 20:30:23 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#210
Delete Branch "feat/issue-204-shared-i18n-keyspace-contract"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?