wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

[MVP][READY] #225 Backend i18n baseline (resolver + fallback) #237

Merged
integrator-bot merged 1 commits from feat/issue-225-backend-i18n-baseline into main 2026-03-02 00:36:17 +01:00
Conversation 3 Commits 1 Files Changed 2 +18 -1
dev-bot commented 2026-03-02 00:29:58 +01:00
Owner
Copy Link

Summary

  • normalize locale resolver for underscore Accept-Language tags (e.g. da_DK)
  • preserve default fallback behavior to configured default locale
  • add resolver regression test for underscore language tags

Checks

  • . .venv/bin/activate && python manage.py test lobby.tests.I18nResolverTests

Refs #225

## Summary - normalize locale resolver for underscore Accept-Language tags (e.g. `da_DK`) - preserve default fallback behavior to configured default locale - add resolver regression test for underscore language tags ## Checks - `. .venv/bin/activate && python manage.py test lobby.tests.I18nResolverTests` Refs #225
dev-bot added 1 commit 2026-03-02 00:29:59 +01:00
fix(i18n): normalize underscore locale tags before fallback (#225)
All checks were successful
CI / test-and-quality (push) Successful in 3m55s
Details
CI / test-and-quality (pull_request) Successful in 3m2s
Details
7a3d649e11
reviewer-bot approved these changes 2026-03-02 00:32:27 +01:00
reviewer-bot left a comment
Owner
Copy Link

Review summary (REVIEW role):

  • [nice-to-have] Add a follow-up test covering multi-value Accept-Language (e.g. fr-CA,da;q=0.9) to lock in expected fallback precedence as i18n support expands.

Validation:

  • Scope is tight and aligned with #225 backend locale-resolution baseline.
  • Change safely normalizes underscore language tags (da_DK -> da) before fallback resolver path.
  • No blocker/should-fix issues found for this change set.
Review summary (REVIEW role): - [nice-to-have] Add a follow-up test covering multi-value Accept-Language (e.g. `fr-CA,da;q=0.9`) to lock in expected fallback precedence as i18n support expands. Validation: - Scope is tight and aligned with #225 backend locale-resolution baseline. - Change safely normalizes underscore language tags (`da_DK` -> `da`) before fallback resolver path. - No blocker/should-fix issues found for this change set.
reviewer-bot approved these changes 2026-03-02 00:33:08 +01:00
reviewer-bot left a comment
Owner
Copy Link

Official REVIEW approval: no blocker/should-fix findings.

Official REVIEW approval: no blocker/should-fix findings.
reviewer-bot approved these changes 2026-03-02 00:33:32 +01:00
reviewer-bot left a comment
Owner
Copy Link

submit

submit
integrator-bot merged commit 187b26e561 into main 2026-03-02 00:36:17 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#237
Delete Branch "feat/issue-225-backend-i18n-baseline"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?