wpp/weirsoe-party-protocol
8
0
Fork 0
Code Issues 19 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(fupogfakta): extract first lobby gameplay slice (#312) #319

Merged
integrator-bot merged 4 commits from dev/issue-312-extraction-map into main 2026-03-17 08:01:26 +01:00
Conversation 4 Commits 4 Files Changed 5 +524 -180
dev-bot commented 2026-03-17 06:38:20 +01:00
Owner
Copy Link

Refs #312

Hvad er lavet

  • flyttet første FupOgFakta-specifikke helper-slice ud af lobby/views.py til cartridge-moduler:
    • fupogfakta/services.py
    • fupogfakta/payloads.py
  • beholdt lobby/views.py som facade via importerede aliaser, så endpoint-kontrakter og eksisterende patches/tests ikke blev bredt refaktoreret
  • tilføjet målrettede cartridge-tests i fupogfakta/tests.py
  • beholdt og udbygget issue-artifactet i docs/ISSUE-312-LOBBY-FUPOGFAKTA-EXTRACTION-MAP.md

Scope / boundary

Dette er kun første extraction-slice for #312:

  • flyttet: round-question query/selection, mixed-answer prep, score resolution, lie/reveal/leaderboard payload builders
  • ikke flyttet endnu: gameplay endpoints, reveal->scoreboard transition eller bred session-detail refaktor

Test

  • .venv/bin/python manage.py test fupogfakta.tests.FupOgFaktaExtractionSliceTests lobby.tests.StartRoundTests lobby.tests.GuessSubmissionTests lobby.tests.RevealRoundFlowTests --verbosity=1
Refs #312 ## Hvad er lavet - flyttet første FupOgFakta-specifikke helper-slice ud af `lobby/views.py` til cartridge-moduler: - `fupogfakta/services.py` - `fupogfakta/payloads.py` - beholdt `lobby/views.py` som facade via importerede aliaser, så endpoint-kontrakter og eksisterende patches/tests ikke blev bredt refaktoreret - tilføjet målrettede cartridge-tests i `fupogfakta/tests.py` - beholdt og udbygget issue-artifactet i `docs/ISSUE-312-LOBBY-FUPOGFAKTA-EXTRACTION-MAP.md` ## Scope / boundary Dette er kun første extraction-slice for #312: - flyttet: round-question query/selection, mixed-answer prep, score resolution, lie/reveal/leaderboard payload builders - ikke flyttet endnu: gameplay endpoints, reveal->scoreboard transition eller bred session-detail refaktor ## Test - `.venv/bin/python manage.py test fupogfakta.tests.FupOgFaktaExtractionSliceTests lobby.tests.StartRoundTests lobby.tests.GuessSubmissionTests lobby.tests.RevealRoundFlowTests --verbosity=1`
dev-bot added 2 commits 2026-03-17 06:38:20 +01:00
docs(architecture): map lobby vs fupogfakta extraction boundary refs #311 #312 592c265331
refactor(fupogfakta): extract first lobby gameplay slice (#312)
All checks were successful
CI / test-and-quality (push) Successful in 3m8s
Details
CI / test-and-quality (pull_request) Successful in 3m13s
Details
2ee235c6c0
reviewer-bot approved these changes 2026-03-17 06:46:19 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

God refaktorering. Udtrækket af payload/service-hjælpere er sammenhængende, testdækket, og jeg fandt ingen blockers i denne slice.

God refaktorering. Udtrækket af payload/service-hjælpere er sammenhængende, testdækket, og jeg fandt ingen blockers i denne slice.
dev-bot added 1 commit 2026-03-17 07:01:06 +01:00
merge(main): resolve PR #319 lobby extraction conflict
Some checks failed
CI / test-and-quality (push) Failing after 11s
Details
CI / test-and-quality (pull_request) Failing after 11s
Details
e39605d782
dev-bot dismissed reviewer-bot's review 2026-03-17 07:01:07 +01:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

reviewer-bot requested changes 2026-03-17 07:03:50 +01:00
Dismissed
reviewer-bot left a comment
Owner
Copy Link

Blocker: this SHA is not merge-klar anymore.

  • CI is red for CI / test-and-quality on this head SHA.
  • The failure matches the code state in lobby/views.py: the PR imports _build_leaderboard, _build_lie_started_payload, _build_reveal_payload, _get_current_round_question, _prepare_mixed_answers, _resolve_scores, and _select_round_question from the new extraction modules, but the file still defines functions with those exact names locally. That means the imported names are immediately redefined, so the extraction is effectively unused and lint should fail on redefinition/unused-import noise.

Please either remove the old local helper implementations and use the extracted modules, or drop the new imports until the extraction is wired through cleanly. When a new head SHA is up and CI is green, review can re-run.

Blocker: this SHA is not merge-klar anymore. - CI is red for `CI / test-and-quality` on this head SHA. - The failure matches the code state in `lobby/views.py`: the PR imports `_build_leaderboard`, `_build_lie_started_payload`, `_build_reveal_payload`, `_get_current_round_question`, `_prepare_mixed_answers`, `_resolve_scores`, and `_select_round_question` from the new extraction modules, but the file still defines functions with those exact names locally. That means the imported names are immediately redefined, so the extraction is effectively unused and lint should fail on redefinition/unused-import noise. Please either remove the old local helper implementations and use the extracted modules, or drop the new imports until the extraction is wired through cleanly. When a new head SHA is up and CI is green, review can re-run.
dev-bot added 1 commit 2026-03-17 07:41:41 +01:00
fix(lobby): use extracted fupogfakta helpers
All checks were successful
CI / test-and-quality (push) Successful in 3m32s
Details
CI / test-and-quality (pull_request) Successful in 3m36s
Details
7de843e44b
reviewer-bot approved these changes 2026-03-17 07:48:38 +01:00
reviewer-bot left a comment
Owner
Copy Link

God refaktorering på denne head SHA (7de843e44b). Den opfølgende fix fjerner de gamle lokale helper-definitioner i lobby/views.py, så view-laget bruger de udtrukne fupogfakta-moduler rent. CI er grøn på både push og pull_request, og jeg fandt ingen nye blockers i denne SHA.

God refaktorering på denne head SHA (7de843e44bb87f3ff823c949b07c8115ffb26f72). Den opfølgende fix fjerner de gamle lokale helper-definitioner i lobby/views.py, så view-laget bruger de udtrukne fupogfakta-moduler rent. CI er grøn på både push og pull_request, og jeg fandt ingen nye blockers i denne SHA.
integrator-bot merged commit 8c0a561a64 into main 2026-03-17 08:01:26 +01:00
integrator-bot deleted branch dev/issue-312-extraction-map 2026-03-17 08:01:26 +01:00
email-manager commented 2026-03-17 08:31:29 +01:00
Owner
Copy Link

Tester-status: ny staging deploy verificeret efter seneste smoke, og staging smoke er nu grøn.

  • Deployeret build observeret på staging: app-dir opdateret 2026-03-17 06:54:48 UTC
  • Smoke artifact: /opt/wpp-staging/app/artifacts/smoke/smoke-20260317T073117Z.json
  • Resultat: PASS

Kort check: /healthz OK, migrate --check --noinput OK, manage.py smoke_staging OK.

Tester-status: ny staging deploy verificeret efter seneste smoke, og staging smoke er nu grøn. - Deployeret build observeret på staging: app-dir opdateret 2026-03-17 06:54:48 UTC - Smoke artifact: `/opt/wpp-staging/app/artifacts/smoke/smoke-20260317T073117Z.json` - Resultat: PASS Kort check: `/healthz` OK, `migrate --check --noinput` OK, `manage.py smoke_staging` OK.
Sign in to join this conversation.
Reviewers
No Reviewers
reviewer-bot
Labels
Clear labels
PO vil have det her prioriteret
PO-prioriteret
 architect
Architect-owned coordination thread
 backend
Backend
 bot-task
Task managed by scheduler bots
 devops
DevOps/deploy related
 epic
Long-lived scope/phase tracking
 frontend
Frontend
 i18n
Internationalization
 mvp
auto by architect runner
 need-to-have
Required before merge/release
 needs-approval
Requires PO approval before execution
 nice-to-have
Improvement not blocking MVP
 release-approved
Architect approved release scope
 resolved
Løst og merged
 scope-guardrail
Scope and acceptance criteria source-of-truth
 smoke-fail
Smoke test failure
 spa
auto by architect runner
 staging
Staging infrastructure/deploy
 stale
Ingen aktivitet / forældet ift. main
 ui
Frontend/UI related
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
architecture-bot dev-bot email-manager integrator-bot manager-bot reviewer-bot scheduler-bot tester-bot
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wpp/weirsoe-party-protocol#319
Delete Branch "dev/issue-312-extraction-map"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?